Implemented The sun rising from the south

Discussion in 'Contributing & RFCs' started by yuko fuyutsuki, Jun 3, 2018.

  1. yuko fuyutsuki

    yuko fuyutsuki Witch

    Messages:
    69
    GitHub:
    fuyutsuki
    Introduction:
    In our world we set the direction as 0 degrees north and 90 degrees east ... and so on. However, it seems not to be so in the world of Minecraft.

    Subject:
    We can get the direction and the corresponding integer value (0 to 3) with the function getDirection() in pmmp world.
    However, referring to this value, the sun will climb from the west as shown in the picture.
    Even in reality, even in Minecraft: JavaEdition, the sun climbs east.
    Should I issue a pull request to fix this?
    [​IMG]

    reference:
    ・Entity::getDirection(): https://github.com/pmmp/PocketMine-...fe01ba/src/pocketmine/entity/Entity.php#L1285
    ・Minecraft: Sun: https://minecraft.gamepedia.com/Sun
     
  2. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin Noobiest member in the PMMP Team

    Messages:
    1,760
    GitHub:
    sof3
    jasonwynn10 and yuko fuyutsuki like this.
  3. yuko fuyutsuki

    yuko fuyutsuki Witch

    Messages:
    69
    GitHub:
    fuyutsuki
  4. Thunder33345

    Thunder33345 Moderator Staff Member Verified

    Messages:
    2,143
    GitHub:
    Thunder33345
    so something ought to be made to correct this inconsistency?
     
  5. yuko fuyutsuki

    yuko fuyutsuki Witch

    Messages:
    69
    GitHub:
    fuyutsuki
    SOF3's bihaviour certainly makes sense.
    But it is very incongruous that the direction is different from Minecraft: JavaEdition(and reality).
     
    Levi, HimbeersaftLP and Thunder33345 like this.
  6. dktapps

    dktapps Administrator Staff Member PMMP Team

    Messages:
    674
    GitHub:
    dktapps
    Changing this will break lots of code that depends on it (block placement for example) so I've avoided touching this at the moment.

    If I remember correctly, the direction values are correct (as commented in the code), but the function returns unexpected results - this needs investigating further.
     
    jasonwynn10 and yuko fuyutsuki like this.
  7. Thunder33345

    Thunder33345 Moderator Staff Member Verified

    Messages:
    2,143
    GitHub:
    Thunder33345
    just hotfix the sun for now?
    since it's generally UI only,
    degrees will break a shit ton of hardcoded plugins doe
    but for consistency some day maybe we could...
     
  8. dktapps

    dktapps Administrator Staff Member PMMP Team

    Messages:
    674
    GitHub:
    dktapps
    the sun is client-sided. It's just that plugins have to differently interpret the results of getDirection().
     
  9. dktapps

    dktapps Administrator Staff Member PMMP Team

    Messages:
    674
    GitHub:
    dktapps
    I know this is an old thread, but it caught my eye... anyway, this bug is fixed in 4.0 development builds.
     
  10. yuko fuyutsuki

    yuko fuyutsuki Witch

    Messages:
    69
    GitHub:
    fuyutsuki
    If you caught your eye this message again, please attach the [Implemented] prefix....
     
    HimbeersaftLP likes this.

Share This Page

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.