Implemented Implementing SkyLight into pmmp

Discussion in 'Contributing & RFCs' started by robske_110 (Tim), Nov 12, 2016.

?

Usage of getFullLight/getSkyBlockLight

  1. In initial PR

  2. In seperate PR

Results are only viewable after voting.
  1. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    I have been working on doing this todo (https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/level/Level.php#L1289) in the last 3 weeks, and a PR will probably be submitted within the next week. This thread is meant for dicussion about this upcoming PR/feature (how it should be implemented and mainly, should i put some usage in already (example: grass) or make a seperate PR.)
    I will provide more info soon(ish).


    If this is at the wrong place, sorry I am new here (probably everyone is :p)
     
    Last edited: Nov 12, 2016
    Skullex, Matthew and SOFe like this.
  2. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    screenshot.jpg
    That's the current debug output..

    Hello there,
    I'm still trying to get this done. The calculation almost does things right, it is just still struggling with vertical light.
    There are some problems to be resolved:
    When should the skylight be calculated? I couldn't quite figure out if light is calculated on chunk load.
    SkyLight theoretically needs to be recalculated overtime anything changes in XZ+-15 blocks. This would be awful for performance.
     
    Skullex and Matthew like this.
  3. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    I just managed adding a forgotten return; that brought performance back. I also moved one line and suddenly realised that almost everything works. I just have to improve performance and squash the little bugs that are flying around.
    It is funny how some small changes can change everything for the good.
    screenshot.png
     
    jasonwynn10, Skullex and Matthew like this.
  4. Sandertv

    Sandertv Zombie Pigman Poggit Reviewer

    Messages:
    786
    GitHub:
    Sandertv
    I agree, would be awesome if this made it through :)
     
    Skullex, robske_110 (Tim) and Matthew like this.
  5. PocketKiller

    PocketKiller Slime

    Messages:
    84
    GitHub:
    iPocket
    Gurun has *done* that...
    on MiNET
     
    dktapps likes this.
  6. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    Thanks for all the support!
    I just got most the freezes sorted out (some constellations still cause a loop), and managed to get many things working. I'm now mainly working on the trouble with the recursive call control, performance, bug fixing and some cleanup before releasing it to the public. Here are
    Theoretically everything would just work perfectly. I just have to deal with the recursive call control.
    some pics:
     
    HimbeersaftLP likes this.
  7. archie426

    archie426 Baby Zombie

    Messages:
    130
    GitHub:
    archie426
    Too right!
     
    HimbeersaftLP likes this.
  8. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    PROGRESS!
    Huge progress!
    I have got all the freezes really sorted out, and I am now working on performance (it takes over 0.1s :eek:)
     
    jasonwynn10 and HimbeersaftLP like this.
  9. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
  10. archie426

    archie426 Baby Zombie

    Messages:
    130
    GitHub:
    archie426
    Nice
     
  11. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    Still thinking about some details, (not-fully-finished) PR will be submitted this week.
     
  12. Dog2puppy

    Dog2puppy Slime

    Messages:
    94
    GitHub:
    dog2puppy
    What is sky lighting? Never heard of it.
     
  13. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    Start MCPC, press F3 and look at Light: 12 (Block:0 Sky:12)
     
    Skullex likes this.
  14. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,356
    GitHub:
    robske110
    Marabou likes this.

Share This Page

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.