sleep() Alternative

When i use Sleep() in my Plugin, the whole server "sleeps". How can i fix that? Here is my Code.

PHP:

<?php

namespace derdumme\info;

use pocketmine\plugin\PluginBase;
use pocketmine\event\Listener;
use pocketmine\utils\TextFormat;
use pocketmine\event\player\PlayerJoinEvent;

class info extends PluginBase implements Listener {
  public function onEnable() {
  $this->getLogger()->info(TextFormat::GREEN."wurde aktiviert.");
  $this->getServer()->getPluginManager()->registerEvents($this, $this);
  }
  public function onDisable() {
  $this->getLogger()->info(TextFormat::RED."wurde deaktiviert.");
  }
  public function onJoin(PlayerJoinEvent $event){
  while(true) {
  $message = random_int(1, 5);
  if($message == 1){
  $event->getPlayer()->sendPopup(TextFormat::GREEN."Teamspeak-Server: ts.skyzonemc.net");
  } elseif ($message == 2) {
  $event->getPlayer()->sendPopup(TextFormat::GOLD."Website: SkyZoneMC.net");
  } elseif ($message == 3) {
  $event->getPlayer()->sendTip("This is a Tip");
  }
  sleep(60);
  }
  }
  
  

}

 

Why would you want to use a while loop and sleep() here? Can't you just remove the while loop and sleep?

 

Why sleep() at all?

Anyways for the entire server sleeping, you could use a delayed task.

 

This is not the way how to do it in PocketMine, use a RepeatingTask instead.
Your thinking was logical, but "while" in a plugin freezes the server.

Original post:

 

It is bad practice for a PocketMine plugin.

 

Is the sense of sleep (60) for breaking the while loop? If yes break the while loop with break;

 

Horrible.

 

And what is a good practice? Im a beginner.

 

The Code should be executed every 60 seconds.

 

Just schedule a repeating task and send a popup for each player every 60 seconds.

 

This is correct way of thinking but you didn't took thread blocking in consideration. Although code is terrible it has some sense in it. Just google "Scheduling Repeating task in PocketMine Tutorial"

 

Edited my post

 

You should use repeating task instead of what you used.
Put this in onEnable() function in your main class

PHP:

//parameters PluginTask $class | $delay
$this->getServer()->getScheduler()->schedulerepeatingtask(new sendTipTask(),60); 

create a new class this task will be repeated with a delay of 60 ticks in between (aprox 3 secs i think)

PHP:

class sendTipTask extends PluginTask {
        private $plugin
        public function __construct(info $plugin){
          parent::__construct($plugin);
          $this->plugin = $plugin;
        }

        public function onRun($currentTick){
          foreach($this->plugin->getServer()->getOnlinePlayers() as $player){
            $messages = [
              "message 1",
              "message 2",
              "etc"
            ];
            $player->sendMessage($messages[array_rand($messages)]);
          }
        }
      }

Hopefully helped. Also now you dont need the PlayerJoinEvent anymore.

 

Im getting this Error:
Fatal error: Declaration of derdumme\info\sendTipTask:nRun() must be compatible with pocketmine\scheduler\Task:nRun($currentTick) in C:\Users\...\Desktop\Server 0.16\plugins\Info - DerDumme\src\derdumme\info\info.php on line 23

 

@BalAnce forgot to add parameter $currentTick for Task :: onRun() method. The error says that your method signature differs from parent. If you don't know what that means, don't worry simply look at this code and correct yours

PHP:

public function onRun($currentTick){


 

Now im getting this error:
[11:44:20] [Server thread/CRITICAL]: TypeError: "Argument 1 passed to derdumme\info\sendTipTask::__construct() must be an instance of derdumme\info\info, none given, called in C:\Users\ik83\Desktop\Server 0.16\plugins\Info - DerDumme\src\derdumme\info\info.php on line 15" (EXCEPTION) in "/Info - DerDumme/src/derdumme/info/info" at line 26