Solved Skip Certain Blocks With getHighestBlock

I've been using getHighestBlock as methods to get the ground, but the maps I use have glass domes, which players spawn on. How can I skip the glass?

 

(This is probably very inconvenient) Uhhhh I think the world height is 256 so get players position in a variable. Run a loop which checks the players position but the the Y position starting from 256, until a block (which isn’t air, glass, water etc) keep taking away the Y by 1 till a valid block is found then return that block position

 

I hope you understand what I’m getting at considering I explained that terribly lool

 

Code example? I've tried to make something like that and it ends up breaking @mm899

 

hmm

 

PHP:

public function getCustomRoof(Player $player){
        $position = $player->getPosition();

        $count = 256;
        $check = true;

        while($check){
            $position->y = $count;
            $block = $player->getLevel()->getBlock($position);
            if($block->getId() != 20 && $block->getId() != 0){ //block isnt glass or air :p - add water/laval(stationary/flowing)
                $check = false;
            }
            else{
                $count--;
            }
        }

        return $position;
    }

I haven't tested this, try this I guess....

 

Do let me know if it worked

 

Don't hardcode block IDs. It's a terrible idea and it makes your code impossible to read.

 

Il bare that in mind thanks for the tip

 

y=256 is one block outside the world, replace $count's value with (Level::Y_MAX - 1) or you could do something like

PHP:

$y = Level::Y_MAX;
while(--$y >= 0){
    $position->y = $y;
}


 

I hadn’t realised the world height (last time I played was 1.11 when it was 128)

 

I fixed the item ids and the $count value like what @Muqsit said, and it works fine, thanks!