problem with the probability calculations?

PHP:

  $rand = mt_rand(1,100);
if($rand<=50){
  $player->getInventory()->addItem(Item::get(264,0,1));
} else if($rand<=20){
$player->getInventory()->addItem(Item::get(368,0,1));
} else if($rand<=30){
$player->getInventory()->addItem(Item::get(265,0,1));
}

When I use this code, It only works in ItemCode 264(diamond). why? I want to make if 50%, give diamond, if 20%, give ender, if 30%, give iron

 

You will need to put the smallest number first, because with your code, even if $rand is smaller than 20, the condition <=50 is still true and it will use that.

 

I changed what you said, but when I tested, it sometimes give nothing. why this problem happening?

PHP:

if($rand<=20){
  $player->getInventory()->addItem(Item::get(265,0,1));
} else if($rand<=30){
$player->getInventory()->addItem(Item::get(368,0,1));
} else if($rand<=50){
$player->getInventory()->addItem(Item::get(264,0,1));
}

 

Did you remove the $rand = mt_rand(1,100); ?

 

PHP:

$rand = mt_rand(1,100);

if($rand<=20){
  $player->getInventory()->addItem(Item::get(265,0,1));
} else if($rand<=30){
$player->getInventory()->addItem(Item::get(368,0,1));
} else if($rand<=50){
$player->getInventory()->addItem(Item::get(264,0,1));
}

NO

 

That's odd, are you sure the code is getting executed?

 

what mean?? It works well, everything is good but a little more frequently, they just take the stones and don't give the items. what problem is this? I need to solve this problem quickly

 

than, How can I make probability?

 

PHP:

 $rand = mt_rand(1,100);
if($rand<=40){
  $player->getInventory()->addItem(Item::get(264,0,1));
} else if($rand<=80){
$player->getInventory()->addItem(Item::get(368,0,1));
} else if($rand<=100){
$player->getInventory()->addItem(Item::get(265,0,1));
}

is this right? 264 's probability is 40%, 368's probability is 80%, and 265's probability is 100%

 

Are you sure?

https://www.php.net/manual/en/function.mt-rand.php

 

than, is this right?

PHP:

$rand = mt_rand(1,15)

if($rand<=5){
sendMessage(probability is 5%);
} else if($rand<=15){
sendMessage(probability is 10%);
}

 

Nope. In first case it's 33.3% and in the second one 66.6%

 

To work out the probability you can use this formula: