Plugin correct code?

PHP:

<?php
#Plugin echo por NintendoCore16

namespace NintendoCore16;

use pocketmine\event\player\PlayerLoginEvent;
use pocketmine\plugin\PluginBase;
use pocketmine\event\Listener;
use pocketmine\utils\TextFormat as c;
use pocketmine\utils\Config;

class Slots extends PluginBase implements Listener {

    public function onEnable(){
        $this->getServer()->getLogger()->info(c::AQUA . "PLUGIN ACTIVADO");
        $this->getServer()->getPluginManager()->registerEvents($this, $this);
        @mkdir($this->getDataFolder());
        $this->saveResource("config.yml");
        $this->Config = new Config($this->getDataFolder() . "config.yml", Config::YAML);
    }

    public function onPlayerLogin(PlayerLoginEvent $event){
        if($event->getReason() === "disconnectionScreen.serverFull"){
            $this->Config = new Config($this->getDataFolder() . "config.yml", Config::YAML);
            if(count($this->getServer()->getOnlinePlayers()) < $this->getConfig()->get("Slots")){
                $event->setCancelled(true);
            } else {
                if($event->getPlayer()->hasPermission("nintendo.slots.full")){
                    $event->setCancelled(true);
                    return;
                }
                $event->setKickMessage("");
            }
        } else if($event->getReason() === "disconnectionScreen.serverFull"){
            $this->Config = new Config($this->getDataFolder() . "config.yml", Config::YAML);
            if(count($this->getServer()->getOnlinePlayers()) < $this->getConfig()->get("Slots")){
                $event->setCancelled(true);
            } else {
                if($event->getPlayer()->hasPermission("nintendo.slots.full")){
                    $event->setCancelled(true);
                    return;
                }
                $event->setKickMessage("");
            }
        }
    }
}

 

We can't magically read your mind and know what your problem is.

 

not problem
my code is bad

 

Why is it bad...

 

You mean...Optimization?

Don't use new Config($path, Config::YAML), use yaml_parse_file($path);

saveResource() call onEnable is useless. Won't affect the performance by a bit tho.

You don't need to redeclare $this->Config again, in PlayerLoginEvent. You have already declared it in onEnable.

Save $this->getConfig()->get("Slots") to a global variable in onEnable(), then call the global variable instead of calling $this->getConfig()->get("Slots").

 

It'd be better if you use camelCase on your variable names.