1. The forums will be archived and moved to a read only mode in about 2 weeks (mid march).

Hello, PMMP! Plugins, maybe?

Discussion in 'General discussion' started by deotern, Nov 15, 2016.

  1. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,342
    GitHub:
    robske110
    https://github.com/poggit/poggit#ci-building that's how it's going to support it
     
    HimbeersaftLP likes this.
  2. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    Having read up on Poggit I am nothing but confused.

    As a person who runs a personal CI server with privately hosted repositories as well as public ones on Github, the mentioned line is just completely out of the question and I would much rather take my work elsewhere if "free open source software" isn't completely optional. The correct solution is to simply use a resource manager and let users upload as they wish.

    TLDR; Please explain to me the steps I would need to take in order to publish a plugin that is not open source or publish my own PHARs as opposed to whatever your "Poggit" creates.
     
    Tux likes this.
  3. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    Your plugin can be extracted anyway. What's wrong with making the source code more easily viewable? Moreover, source code must not be obfuscated, so I don't really know what you are having trouble with. At most you just create another repo to contain the raw code in the extracted phar.
    Could you suggest any possibilities what you want to put in your phar file, apart from resources folder, src code, a plugin.yml and some stub files?
    Even if you do not want to use the project models supported by Poggit, we can still manually add new models to Poggit if it is needed.
    It can integrate with Travis-CI, which can wait for a build to be created.
    Otherwise you can just make a separate build on Travis CI. Poggit still saves the trouble of deployment when a lot of setup and encryption work has to be done with Travis CI.
     
    HimbeersaftLP likes this.
  4. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    My problem with this is that I cannot justify defending code that is openly available and not everyone has a wish to open source their projects. If your stance is that well since code can be extracted or decompiled then every project ever should be open source, then I expect this place to become a second class citizen in the race to take over for the original pocketmine forums.

    You simply alienate a lot of developers by enforcing open source only. Remember the paid plugins discussion over at pocketmine.net? Quite a lot of people seem to be willing to pay for premium quality plugins, it doesn't speak to the open source ideology but I'm getting too old for that, there's bills to pay as an adult.

    Don't take this as a "I want to be able to sell plugins on here!", it's just an example of an entire genre (premium plugins) that simply cannot happen if you demand open-source projects only. Personally it's because I do not want to open source the client plugin I am writing for a service I have.
     
    HotFireyDeath likes this.
  5. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    I don't demand open-source plugins. But if Poggit doesn't allow posting paid plugins anyway, what's the meaning of that?
     
    HimbeersaftLP likes this.
  6. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    Again, do not take it as a "I want paid plugins" post. That's merely an example.

    If poggit is the only way we can publish plugins and poggit demands a public repository... what the heck do you do when you do _not_ want to publicise your repository??
     
  7. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    I still don't understand. If you don't want to publicize your original private repository (why? Is it because there aee private plugins there?), can't you make another one?

    Actually we are already discussing in the team about removing this limitation.
     
    HimbeersaftLP likes this.
  8. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    Another question is, why do you want to upload phars instead of letting Poggit build code from your source code?
     
    HimbeersaftLP likes this.
  9. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    I am a power user. I run my own dedicated server with Jenkins and my own scripts to build my projects. If I don't want my repos publicly available then obviously I wouldn't want Poggit to access them either to build the PHARs. I trust no one but myself with building my plugins for various reasons. Obviously a scary thought if the main poggit server were to get compromised, how long it could take to notice or how every project would be immediately affected.
     
  10. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    As a matter of fact, Poggit requires GitHub repo scope access to login, so it would get permissions to access your private repos anyway. Of course you can still revoke the token anytime, or uncheck that option when authorizing.
     
    HimbeersaftLP likes this.
  11. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    Then if that is the only way to publish plugins on pmmp.gq then I'm not going to be able to use the site and I doubt I will be the only one.
     
  12. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    I see your point, and I definitely did realize that. I still think you're a bit paranoid, but that's how Poggit works after all. I'll see if I can make it possible to submit plugins without the need to create a repo associated to it, but that'd be probably very much trouble.
     
    HimbeersaftLP likes this.
  13. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    I forgot to mention that public repos were originally forced because we wanted it to be easier for plugin reviewers to view the plugin's changes since the last version, or just to use the GitHub interface for viewing code.
     
    HimbeersaftLP likes this.
  14. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    What is your opinion if Poggit extracts the phar and upload the code to a GitHub repo (under Poggit org) if you upload a phar?
     
    HimbeersaftLP likes this.
  15. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    I wouldn't want my extracted code uploaded to a public repository. Plus this also makes you vulnerable to DMCA takedowns. :)
     
  16. HimbeersaftLP

    HimbeersaftLP Fish

    Messages:
    2,402
    GitHub:
    HimbeersaftLP
    Don't do illegal stuff and you won't be taken down...
     
  17. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    You really don't understand?

    I can DMCA Poggit if they extract my code and publish it in a public repository. And so can everyone else that makes a plugin.
     
  18. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    As a matter of fact I still don't understand why you are so paranoid about making your source code accessible directly while your phar containing the source code is already publicly available.
     
    HimbeersaftLP likes this.
  19. ProjectInfinity

    ProjectInfinity Witch

    Messages:
    58
    GitHub:
    projectinfinity
    You may not understand it, but at a certain point you don't want to make the source of every project you work on public. Yes it's ridiculously easy to unpack the PHAR but who cares. The point is if the source isn't available out there, it's less likely someone will take a look at your work or even copy it. You shouldn't exclude closed source just because YOU don't understand it.

    Not trying to come off like an ass but your stance on the subject seems to come from a fairly ideological standpoint. And I get it. I was there 8 years ago.
     
  20. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    But seriously 10 people copying it and 100 people copying it is still the same :D
     
    HimbeersaftLP likes this.
  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.