Transfer on login

If the player is transferred (Player::transfer()) in PlayerPreLoginEvent or PlayerLoginEvent, should the event be cancelled?

 

If not cancelled, server will continue to evaluate the user login.

 

The player will be closed when they are transferred. That might cause some issues, not sure.

 

sidenote; shouldnt this be in RFCs?
it should be evaluated as kicked
problem lies in, some plugin would need that to example, logging of users
some plugin would use @prioritity MONITOR which if it's canceled they cant log it
but some plugins would try to do something like send message which i suspect will cause issues
i think no, developers are responsible of checking players are online, or to use a hack of delayed transfer thus allowing plugins to do whatever they needed to do without breaking everything

 

No need to log. In Player->transfer(), the player is closed anyway. If they ignore cancelled events, they don't want to log kick players.
Plugins shouldn't handle kicked players.

 

yes i acknowledge that's the worst example, what if a plugin just want to log even kicked players?
we shouldnt assume no one will want to do that and panic when we realize there's no way to do such
maybe i should just abandon my bad analogy
propose would be a disconnect reason transferred on connect

 

Then the plugin should either not handle the event at MONITOR priority or should not enable ignoreCancelled.