SQLITE3 numbers going negative even though i made it minus

in my queries

Code:

-- #    {reduce_money
-- #        :username string
-- #        :money int
UPDATE economy
SET money = money - :money
WHERE player = :username;
-- #    }

the method

PHP:

public static function reduceMoney(Player $player, int $amount)
    {
        $plugin = MainClass::getInstance();
        $plugin->provider->executeChange("reduce_money", [
            "username" => $player->getName(), "money" => $amount
        ]);
    }

when i reduce money(my current money is 80,000,000btw)

PHP:

EconomyAPI::reduceMoney($player, 60000000);

it gives me -60000000 in the database

 

You didn't get the value of 'money' first, so the result will be 0 - :money.

 

Because he wants to deduct the value he sends to that function from the current value in his db - doesn't he have to select the value first?

 

Move this to facepalm. You reduce the money, you take them, you get them away. Maybe addMoney or EconomyAPI::reduceMoney($player, -60000000); or setMoney($player, $currentMoney - 60000000)

 

It sounds pretty obvious,

PHP:

$money = 0;
function reduceMoney(int $reduce){
    $money = $money - $reduce;
}

reduceMoney(6000000);
//0 - 6000000? -6000000


You could use SQLite3's MAX() function to cap the value you're setting.

Code:

UPDATE table SET value=MAX(0, value - value - 1);
//value = 0

 

Looks to me like we are all assuming different things are happening in the code that the OP didn't post. Yet again, please post links to your plugin on github, or complete code.

 

what?

 

Indeed... according to https://sqlite.org/lang_update.html:

So you've messed up elsewhere, and we can't know where from the information you posted.