Player error

Hi. If a player runs my command, it crashes my server. If i run it in the console it works.

I already found the issue. But I don't know what I can do. I give the player using a variable to a different class.

PHP:

private $ip, $port, $timeout, $server, $status, $online, $max, $type, $player;
public function __construct($ip, $port, $type, $player, $timeout = 10){
    $this->ip = $ip;
    $this->port = $port;
    $this->timeout = $timeout;
    $this->player = $player;
//If I remove $this->player the server doesn't crash
    $this->type = $type;
}

 

Show us your whole code please. We can't do anything with this.

 

This is where I start the task. But it has something to do with the first code. It only crashes if I use $this->player = $player and $player is not the console

PHP:

$status = $this->getServer()->getScheduler()->scheduleAsyncTask($task = new StatusTask($ip, $port, $type, $player, $timeout));

 

The amount of code that you have given us is useless. Please show it all for us to be able to help.

 

Serialization of closure is not allowed. You can't pass a Player::class to an AsyncTask directly (assuming $player is an instance of Player).

 

But what if I run it from console? Than isn't it a player

 

You will get the same error

 

No. If u read the question u would know that

 

Classes extending other classes can generally be serialized. I can't find any info on when serialisation will not be working anymore.
This still works:

PHP:

<?php
class SomeRandomObject{
    public $aaa = "ftw";
   
    public function test1(){
        echo("test1");
    }
}
class ComplexClass extends SomeRandomObject{
    public $notThatComplex = 0;
    public $sth = "sth";
    public $array = [0 => 'aa', 'strindex' => 4];
   
    public function __construct(int $arrAddVal){
        $array[1] = $arrAddVal;
    }
   
    public function test2(){
        echo("test2");
    }
}
$complexObject = new ComplexClass(10);
class IwantAnObject extends Thread{
    protected $myObjectAsABLOB = null;
   
    public function __construct(ComplexClass $myObject){
        $this->myObjectAsABLOB = serialize($myObject);
    }
   
    public function run(){
        echo("Thread #".$this->getThreadId()." is running.\n");
        $myObject = unserialize($this->myObjectAsABLOB);
        var_dump($myObject);
        $myObject->test2();
        $myObject->test1();
        var_dump($myObject->aaa);
    }
}

$thread = new IwantAnObject($complexObject);
$thread->start();
while(true){sleep(10);}


 

You can't get anything that holds \pocketmine\Server into async, that includes ConsoleCommandSender and player.

 

Yeah, it isn't like "Oh, sending players 20 custom nbt tagged items lags, let me just push that into an async task."
AsyncTask isn't what can always save you from the big "sleep". Try using it to pass heavy PHP functions. Maybe a heavy 3 dimensional for loop?

 

Hmm, I still don't get what you are trying to accomplish here? We can always find a different method.

 

To the OP's code.