Player Count

When a player is in a particular gamemode it will add to count on HUD

This doesn't seem to work?

PHP:

foreach($this->plugin->getServer()->getOnlinePlayers() as $player){
    foreach($player as $p){if($p->isSurvival()){$survival=$survival+1;}}
    foreach($player as $p){if($p->isSpectator()){$spectator=$spectator+1;}}

 

Wtf? Why are you foreaching already foreached array?

Try this:

PHP:

foreach($this->getServer()->getOnlinePlayers() as $p){
        if($p->getGamemode() == Player::SURVIVAL){
          $survival++;
        }
        if($p->getGamemode() == Player::SPECTATOR){
           $spectator++;
        }
}

 

Why are you checking if a player is a spectator AFTER you've already checked if they're in survival?

PHP:

$survival = $spectator = 0;
foreach($this->getServer()->getOnlinePlayers() as $p) {
        if($p->getGamemode() == Player::SURVIVAL) {
          $survival++;
        } elseif($p->getGamemode() == Player::SPECTATOR) {
           $spectator++;
        }
}


 

There's a bracket after checking for Survival, so it don't make big difference

 

A simple gamemode check may not be a big difference in performance but it's bad practice. If the check costs more CPU time then it becomes a performance problem.