1. The forums will be archived and moved to a read only mode in about 2 weeks (mid march).

Solved Issues EventListener/PlayerKickEvent when player banned or no Xbox live connection

Discussion in 'Help' started by TeraCube, Nov 27, 2017.

  1. TeraCube

    TeraCube Zombie

    Messages:
    262
    GitHub:
    teracube
    Help
    Could you please look at this issue :

    https://github.com/CortexPE/TeaSpoon/issues/61

    This issue happened when a player try to connect
    • banned player
    • player not identified on XboxLive
    plugin developper said say's it probably a PMMP issue (not a plugin issue)
    He said

    Sadly, there isn't much that we can do regarding that issue...

    2017-11-26 [04:29:12] [Server thread/CRITICAL]: TypeError: "Return value of pocketmine\entity\Entity::getId() must be of the type integer, null returned" (EXCEPTION) in "src/pocketmine/entity/Entity" at line 1840

    as this line defines the error as a "TypeError" from pocketmine/entity/Entity,it occurs BEFORE the return value of Entity::getId() (which is STRICTLY set to be int) is passed to TeaSpoon's EventListener...

    You can ask for PMMP to fix this bug since this is being handled by PMMP's Entity class.



    What is your opinion

    sorry for my french accent ;-)
     
  2. robske_110 (Tim)

    robske_110 (Tim) Wither Skeleton Poggit Reviewer

    Messages:
    1,342
    GitHub:
    robske110
    I think the entity isn‘t really completly initialized if the player is banned/not logged in. That‘s why there is no entity id.
     
    Awzaw and Sandertv like this.
  3. Awzaw

    Awzaw Zombie Pigman Poggit Admin

    Messages:
    726
    GitHub:
    awzaw
    Ask them if it's too much work to add this before getId()

    PHP:
    if (!$p->isOnline()){
    return;
    }
     
    HimbeersaftLP and TeraCube like this.
  4. HBIDamian

    HBIDamian HBIDamian Staff Member

    Messages:
    365
    GitHub:
    HBIDamian
    It's best to discontinue the plugin... and start again. Then spend a massive amount of time fixing the bugs before releasing it again
     
  5. TeraCube

    TeraCube Zombie

    Messages:
    262
    GitHub:
    teracube
    i suggest it to dev
    thanks
     
  6. Awzaw

    Awzaw Zombie Pigman Poggit Admin

    Messages:
    726
    GitHub:
    awzaw
    It's not released on Poggit, there are too many bugs
     
  7. HBIDamian

    HBIDamian HBIDamian Staff Member

    Messages:
    365
    GitHub:
    HBIDamian
    I didn't say it was. ;)
     
  8. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    I don't understand why TeaSpoon exists... It's too large to maintain, so it's really easy to get something broken as long as PMMP updates something. Since these should be core features, it's much more reasonable to add them to the core so that whenever something is refactored, they get immediately updated too.
    Of course, not to mention that you can't even track who's the author of the code...
     
  9. TeraCube

    TeraCube Zombie

    Messages:
    262
    GitHub:
    teracube
    fixed on latest buid
    thanks Awzaw
     
  10. dktapps

    dktapps Administrator Staff Member PMMP Team

    Messages:
    774
    GitHub:
    dktapps
    TeaSpoon is a copy-paste of everything from other actual spoons, into a plugin. No originality to it.
     
  11. SOFe

    SOFe Administrator Staff Member PMMP Team Poggit Admin

    Messages:
    1,968
    GitHub:
    sof3
    upload_2017-11-29_23-57-22.png
    Indeed, there is too much impurity.
     

    Attached Files:

    HimbeersaftLP likes this.
  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.