Help pages for my plugin wont work.

xXSirButterXx · Jul 13, 2017

So im making a plugin (Not going into detail), and im having some issues with my help page.

PHP:

case "help": if($sender->hasPermission("troll.cmd") || $sender->hasPermission("troll.cmd.help")){ if(count($args) < 1){ $sender->sendMessage($this->prefix . "Usage: /trollboss help <number>"); if(isset($args[1]){ switch($args[1]){ case "1": $sender->sendMessage("Test1"); break; case "2": $sender->sendMessage("Test2"); break; } } } }else{ $sender->sendMessage($this->prefix . $this->NO_PERM); } break;

Whenever I type /trollboss help <number> nothing happens. I was wondering if there is a fix for this or a better

EdwardHamHam · Jul 13, 2017

Can you show us your plugin.yml please?

Awzaw · Jul 13, 2017

If $args[1] is set, count($args) > 1, so your switch block will never run.

Muqsit · Jul 13, 2017

Awzaw said: ↑

If $args[1] is set, count($args) > 1, so your switch block will never run.
Click to expand...

PHP:

$array = [1 => "hello"]; echo isset($array[1]) ? count($array) : 0; //returns 1

Intyre · Jul 13, 2017

Muqsit said: ↑

PHP:

$array = [1 => "hello"]; echo isset($array[1]) ? count($array) : 0; //returns 1

Click to expand...

PHP:

$array = ["hello"]; // normal array echo $array[0]; // prints hello $array = [1=>"hello"]; // array with key => value echo $array[1]; // prints hello

Both have a size of 1 but they are different.

Awzaw · Jul 13, 2017

Muqsit said: ↑

PHP:

$array = [1 => "hello"]; echo isset($array[1]) ? count($array) : 0; //returns 1

Click to expand...

That's irrelevant here - his count comes before isset, so if the command is /trollboss help 1, (or just /trollboss help), the count is 2 (or 1...) and the code is never run

HBIDamian · Jul 13, 2017

xXSirButterXx said: ↑

So maybe something like this would be a better way to write it.

Code:

                   case "help":
                       if($sender->hasPermission("troll.cmd") || $sender->hasPermission("troll.cmd.help")){
                           if(!isset($args[1])){
                               $issuer->sendMessage("Help page 1");;
                                } else{
                               if(is_numeric($args[1])){
                                   switch($args[1]):
                                       case 1:
                                           $sender->sendMessage("Help page 1");      
                                       break;
                                        case 2:
                                           $sender->sendMessage("help page 2");
                                       break;
                                       case 3:
                                           $sender->sendMessage("help page 3");
                                       break;
                                        ;
                               } else {
                                   $sender->sendMessage($this->prefix . "Invalid syntax, /trollboss help <1|2|3>");
                               }
                            }
                       } else {
                           $sender->sendMessage{$this->NO_PERM);
                       }
                   break;

Would that work better?

Click to expand...

A lot is wrong with that. Syntax errors, and stuff that doesn’t exist.
(For example $issuer... use $sender instead.)

You have semicolons that don’t need to be there.
And (doesn’t really effect the code as much) your formatting -.-

I’m not doing the code for you. I’m just giving you some pointers.

xXSirButterXx · Jul 13, 2017

My mistakes

Help pages for my plugin wont work.

xXSirButterXx Witch

EdwardHamHam Skeleton

Awzaw Zombie Pigman Poggit Admin

Muqsit Chicken

Intyre Administrator Staff Member PMMP Team

Awzaw Zombie Pigman Poggit Admin

HBIDamian HBIDamian Staff Member

xXSirButterXx Witch