Update To EconomyJob?

EconomyJob has an option to use Place to give money, except when you place blocks like seeds and saplings you still get money when the place event is canceled. Allowing players to rack up alot of currency rather quickly.

Code:

 
public function onBlockPlace(BlockPlaceEvent $event){
       $player = $event->getPlayer();
       $block = $event->getBlock();

       $job = $this->jobs->get($this->player->get($player->getName()));
       if($job !== false){
           if(isset($job[$block->getID().":".$block->getDamage().":place"])){
               $money = $job[$block->getID().":".$block->getDamage().":place"];
               if($money > 0){
                   $this->api->addMoney($player, $money);
               }else{
                   $this->api->reduceMoney($player, $money);
               }
           }
       }
   }

 

Which exact version of EconomyJob, and which plugin is cancelling the BlockPlace event? It's probably the priority and @ignoreCancelled tags are not set correctly in one or both, so I'd need to see the full code of both.

 

I never really thought of that, I use WorldProtect to stop the placement of some blocks, but thats not the case in this issue.

the place event is canceled because you are only allowed to plant seeds in farmland, if you try to plant seeds anywhere else the place is canceled but you still get money.

I use the current version of EconomyJob Plugin Found on Poggit

I also use the latest Version of WorldProtect, I have tested both place and break items that have been banned+ unbreakable. you do not recive money when those items are placed,broken.

I think its simply not registering that you are attempting to use seeds on not farmland.

 

So it's pocketmine cancelling the event? The version of EconomyJob I use is set at @priority MONITOR for the BlockPlaceEvent, so I'd try changing that first.

 

correct, I edited my above reply with some more info. im not the best with php, would you mind sharing / updating the Poggit plugin?

 

@Awzaw the @ignoreCancelled is set to true in EconomyJobs

 

So in theory it should not be giving money when the place is cancled?

 

@cancelIgnored indicates that EconomyJobs ignores when the action is cancelled and addes the money anyway. It was made to be like that.

 

weird? not sure why. am I able to disable it?

ps. I also sent you the map.zip you request