I was just looking at the old PocketMine-MP repository and noticed that there are many old PRs that were never implemented into original or the new software. Any thoughts on this? Another thing is that @PeMapModder reviewed each one with @shoghicp and approved them to be merged, but they never actually merged them.
For a few examples, these PRs will work with PMMP and will still add in their respective features: Cacti + Sugarcane Melting Ice and snow layers escaping periods in setNested
pmmp/PocketMine-MP is an official migration of PocketMine/PocketMine-MP [1] (i.e. they are the same project). Pull requests formerly sent to PocketMine-MP wouldn't have got It is probably silently agreed that by sending a pull request and not closing it you agree to have your code used by PocketMine without explicit credits. All credits you need to get is having your name in the commit history. Or simply git-merge. I don't know why people these days love cherry-pick so much. They simply break the initial purpose of Git --
Can we add any of these PRs to PMMP? https://github.com/PocketMine/PocketMine-MP/pull/3400 https://github.com/PocketMine/PocketMine-MP/pull/3392 https://github.com/PocketMine/PocketMine-MP/pull/3399 https://github.com/PocketMine/PocketMine-MP/pull/3525