I can't cancle the EntityRegainHealthEvent with this code. Why? [BUG?]

Code:

public function onRegain(EntityRegainHealthEvent $event)
    {
        $player = $event->getEntity();
        if($player instanceof Player) {
            $reason = $event->getRegainReason();
            if ($reason === EntityRegainHealthEvent::CAUSE_SATURATION) {
                $event->setCancelled(true);
            }
        }
    }

 

At first, how can we know if the Event::setCancelled() has executed? I'm personally not going to test this code.

I just looked through uses of this Event (class) on https://github.com/pmmp/PocketMine-MP/tree/8ced6547f20a1510d823dc316febe87bf7837a94 and I didn't see how it can not work if you really cancel the Event.

 

I tested this code with this:

Code:

public function onRegain(EntityRegainHealthEvent $event)
    {
        $player = $event->getEntity();
        if($player instanceof Player) {
            $reason = $event->getRegainReason();
            if ($reason === EntityRegainHealthEvent::CAUSE_SATURATION) {
                $event->setCancelled(true);
                print_r("Hey");
            }
        }
    }

And it put out "Hey", but it didn't cancle the regainevent

 

Yes they regain

 

It still doesn't work...
Players regain after getting damage. I think its a bug.
Tested with "PocketMine-MP_1.6.1dev-80_92bd1a75_API-2.1.0.phar"

 

I think that you don't know what I mean. I want to cancel the regainevent. But when I cancle it, it still regains..

 

That worked for me that's what I had to do just set the players health to its original- 1 on the event and should work

 

Thank you for this nice idea

 

I thought a player only could heal one heart at a time (I was using it to stop natural food regen might me extent for others)btw I'm suppert

 

yeah but I mean tbh idk a efficient way to go about that and not sure it is worth that rare occasion(depending on what your doing)

 

Make sure you're registering your event listener or your event functions won't get called. While it seems like a stupid mistake that no one would make it happens quite often.

If you're still having problems put some debug code around Player::setHealth() and your listener and make sure they're both called.

 

Format this to your code

PHP:

public function onEntityRegainHealthEvent(EntityRegainHealthEvent $event) {
        if ($event->getRegainReason() == EntityRegainHealthEvent::CAUSE_EATING)
                {
                    $player = $event->getEntity();
                    $level = $player->getLevel()->getFolderName();
        {
                $event->setCancelled();
        }
                }
                elseif ($event->getRegainReason() == EntityRegainHealthEvent::CAUSE_SATURATION)
                {
                    $player = $event->getEntity();
                    $level = $player->getLevel()->getFolderName();
        {
                $event->setCancelled();
        }
                }
    }

 

I have tried it he is right I made sure it was being called just doesn't work and I too have no clue why(haven't looked into it a ton)

 

Here's the issue. While it may seem as if they are regenerating health via vanilla Minecraft, your health on the server SHOULD stay the same. This has to do with the SetHealthPacket I believe. I've had issues regarding this in the past.